Skip to content

fix(app-dependencies): include certain dependencies only when answering yes to their prompts #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2014

Conversation

kingcody
Copy link
Member

Optionally included [dev]dependencies:

  • socket.io (dependency)
  • socketio-jwt (dependency)
  • grunt-contrib-coffee (devDependency)
  • grunt-contrib-jade (devDependency)
  • grunt-contrib-less (devDependency)
  • grunt-contrib-sass (devDependency)

…es to their respective prompts

Optionally included [dev]dependencies:
- socket.io (dependency)
- socketio-jwt (dependency)
- grunt-contrib-coffee (devDependency)
- grunt-contrib-jade (devDependency)
- grunt-contrib-less (devDependency)
- grunt-contrib-sass (devDependency)
@kingcody kingcody changed the title fix(dependencies): include certain dependencies only when answering yes ... fix(app-dependencies): include certain dependencies only when answering yes to their prompts Jul 12, 2014
@JaKXz JaKXz added the bug label Jul 12, 2014
@JaKXz
Copy link
Collaborator

JaKXz commented Jul 12, 2014

👍

@kingcody
Copy link
Member Author

BTW, I was going to only include compass when answering yes to sass; however I don't know enough about the compass workflow to know whether or not its needed w/o having sass.

Maybe someone could be kind enough to fill me in? For now though, grunt-contrib-compass and bootstrap-sass-official are still included regardless of prompts.

Perhaps they can be exclusive to the sass prompt?

DaftMonk added a commit that referenced this pull request Jul 13, 2014
fix(app-dependencies): include certain dependencies only when answering yes to their prompts
@DaftMonk DaftMonk merged commit 5073e13 into angular-fullstack:master Jul 13, 2014
@DaftMonk
Copy link
Member

I removed contrib compass since it was no longer used. bootstrap-sass-offical can be exclusive to sass prompt, I'll update that.

@kingcody kingcody deleted the fix/package.json branch August 13, 2014 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants